fix(libs/form-builder): add capacity to change the default behavior 'onChange' #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fffjacquier
added
🐞 bug
fffjacquier
added
the
🧑⚖️ Tech review needed
fffjacquier
requested review from
EtienneDOYON,
yfrommelt,
jpoissonnet,
TGianella and
piouPiouM
fdubost
reviewed
Jun 21, 2024
| @@ -35,7 +35,7 @@ export interface FormBuilderProps { | |||
| onSubmit: SubmitHandler<FieldValues>; | |||
| onNextStep?: (value: UnpackNestedValue<FieldValues>) => void; | |||
| defaultValues?: DefaultValues<FieldValues>; | |||
| behavior?: keyof ValidationMode; | |||
| behavior?: keyof ValidationMode | 'onChangeTriggerByField'; | |||
There was a problem hiding this comment.
No need to add this new possible value in docs? 👀
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 74.68% 72.65% -2.03%
==========================================
Files 28 28
Lines 391 395 +4
Branches 125 127 +2
==========================================
- Hits 292 287 -5
- Misses 64 67 +3
- Partials 35 41 +6 ☔ View full report in Codecov by Sentry. |
fffjacquier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got an issue in our main project: when typing the email (as the login in register form) we check on the onChange if the email is already taken or not with a backend request (via gigya).
Once this is done, we discovered that on the next field (password), each keydown was also firing the onChange event with all the validation methods assigned from all the fields.
Description
The fix made is to use the onSubmit event instead of the onChange and pass this behavior as a parameter in order not to risk breaking all our forms.
Related Issue
Can't reproduce on this repo.
Types of changes
Checklist